-
Notifications
You must be signed in to change notification settings - Fork 109
Common tests #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Common tests #2474
Conversation
2a200d0
to
d969796
Compare
Slowly making the way through all of your contributions here @mrginglymus. This one is a little meatier, so I can't promise I get through it very quickly, but if you'll catch up to |
3d5a521
to
803cc86
Compare
Amazing, thanks @Westbrook! All up to date now. One outstanding bit of work on this is checking how 'skipped' appears on the output docs - we obviously don't have nay currently skipped tests. |
Created a branch (#2513) to demonstrate a skipped test. This shows effectively as a fail (or a 'not pass') on the front page: ![]() and a skip on details: ![]() |
Do we want to count skipped tests as fails on this headline (show 14/16) or do we want to not count them at all (show 14/14, 100%). The first option doesn't seem particularly fair, the second isn't particularly accurate.... |
There aren't currently skipped tests, right? Do you foresee expanded to skipped tests in the near future? |
Skipped tests will happen when a new test is added that requires a new component. Until that component is implemented in each framework, it will show as skipped. The benefit of this PR is that adding or modifying a test will immediately be reflected in all frameworks. The downside is that adding a test that requires a new component requires that component to be implemented in each framework. Making unimplemented components skip tests I felt was a reasonable compromise to allow us to continue to add new tests without being fully blocked by the tedium of having to implement every framework. Obviously we should aim for complete coverage, but at least for local development having tests skip instead of fail will make the process smoother |
I've just tried using this to add an
otherwise one has to update all the files (which is tedious when considering scores) when adding a test. |
See mrginglymus#1 for an example new + partially implemented test |
Adding a new test was a bit of a PITA due to the sheer number of libraries involved.
This proposed change (with example implementations in riot and react) moves all test definitions to a common location, with frameworks only having to invoke them with a set of factory functions.
This should hopefully make it easier to:
I can't see what skips will look like until #2475 is merged :)
I may pick off a few others to test this works, but I wont commit to completing until it's approved in principle.